Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added language to ace message sent event #36155

Merged
merged 3 commits into from
Jan 31, 2025
+8 −4
Merged

chore: added language to ace message sent event #36155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ee8cf2
chore: added language to ace message sent event
eemaanamir Jan 22, 2025
b33ae24
fix: fixed lint errors
eemaanamir Jan 23, 2025
bb091cf
chore: updated ace version
eemaanamir Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lms/djangoapps/bulk_email/signals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ def ace_email_sent_handler(sender, **kwargs):
user_id = recipient.get('user_id', None)
channel = message.get('channel', None)
course_id = context.get('course_id', None)
message_language = message.get('message_language', None)
translation_language = message.get('translation_language', None)
if not course_id:
course_email = context.get('course_email', None)
course_id = course_email.course_id if course_email else None
Expand All @@ -56,5 +58,7 @@ def ace_email_sent_handler(sender, **kwargs):
'course_id': course_id,
'user_id': user_id,
'user_email': email_address,
'message_language': message_language,
'translation_language': translation_language,
}
)
2 changes: 1 addition & 1 deletion requirements/edx/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ drf-yasg==1.21.8
# via
# django-user-tasks
# edx-api-doc-tools
edx-ace==1.11.3
edx-ace==1.11.4
# via -r requirements/edx/kernel.in
edx-api-doc-tools==2.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/development.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,7 +661,7 @@ drf-yasg==1.21.8
# -r requirements/edx/testing.txt
# django-user-tasks
# edx-api-doc-tools
edx-ace==1.11.3
edx-ace==1.11.4
# via
# -r requirements/edx/doc.txt
# -r requirements/edx/testing.txt
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/doc.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ drf-yasg==1.21.8
# -r requirements/edx/base.txt
# django-user-tasks
# edx-api-doc-tools
edx-ace==1.11.3
edx-ace==1.11.4
# via -r requirements/edx/base.txt
edx-api-doc-tools==2.0.0
# via
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ drf-yasg==1.21.8
# -r requirements/edx/base.txt
# django-user-tasks
# edx-api-doc-tools
edx-ace==1.11.3
edx-ace==1.11.4
# via -r requirements/edx/base.txt
edx-api-doc-tools==2.0.0
# via
Expand Down
Loading