[Attempt 2] refactor: Clean up lms/envs/production.py cruft #36131
+225
−678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reintroduces commit 1593923, which was reverted due to a typo. The typo is fixed in the commit immediately following this one. Co-Authored-By: Feanil Patel <[email protected]>
kdmccormick
force-pushed
the
kdmccormick/lms-envs-production-cleanup-2
branch
from
b70d54a to
c0cb126
Compare
|
Note: Test plan being discussed in Slack, with request not to merge without a plan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting information
Re-introdues #36115, which was reverted by #36129 due to a typo.
The typo fix is included as a separate commit.
Other information
There is an ongoing discussion of how to better safeguard against bugs like the one that led to the revert: #36129 (comment)
Merge considerations
I will wait until Tuesday Jan 21 to merge this.