Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CODEOWNERS with new team names #34352

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Conversation

jristau1984
Copy link
Contributor

Continuing maintainership updates for 2U 2024.

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@jristau1984 jristau1984 requested review from kdmccormick and a team March 12, 2024 02:50
@jristau1984
Copy link
Contributor Author

@kdmccormick this change requires adding write access to two new teams into edx-platform. Is this something you can do within the scope of this ticket, or do I need to file an Axim Engineering issue for it?

@kdmccormick kdmccormick self-assigned this Mar 19, 2024
Comment on lines +9 to +10
common/djangoapps/student/models/__init__.py @openedx/2u-tnl
common/djangoapps/student/models/course_enrollment.py @openedx/2u-tnl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feanil , the error here states that 2u-tnl needs write access. Right now they have read access on the repo. When I bump the access level up to "write", the error here goes away.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, Kyle, I misunderstood your question, I thought it was about adding people as reviewers and not for adding them as CODEOWNERS. Yes, you're right they do need write access and I think it's fine to add them explicitly to the list of collaborators for edx-platform.

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jeremy!

@kdmccormick kdmccormick merged commit f18629e into master Apr 17, 2024
65 checks passed
@kdmccormick kdmccormick deleted the gh-team-update branch April 17, 2024 20:42
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

KyryloKireiev pushed a commit to raccoongang/edx-platform that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants