-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add email cadence setting for email notifications #34241
Conversation
fa5c76a
to
8d9a2ba
Compare
8d9a2ba
to
399bab3
Compare
790a94a
to
9c00b13
Compare
9c00b13
to
3b9d054
Compare
3b9d054
to
702b6f3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit. Rest looks good
It would be better to create a copy of list and remove email_cadence
. This will improve code readability. Indexing/Slicing makes it hard to read and interpret code.
702b6f3
to
40a3bd6
Compare
40a3bd6
to
7c81c16
Compare
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
INF-1251
Description
Add email cadence setting for all notifications.