Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add email cadence setting for email notifications #34241

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

saadyousafarbi
Copy link
Contributor

@saadyousafarbi saadyousafarbi commented Feb 15, 2024

INF-1251

Description

Add email cadence setting for all notifications.

@saadyousafarbi saadyousafarbi force-pushed the saad/INF-1251 branch 3 times, most recently from fa5c76a to 8d9a2ba Compare February 16, 2024 09:44
@saadyousafarbi saadyousafarbi force-pushed the saad/INF-1251 branch 4 times, most recently from 790a94a to 9c00b13 Compare March 18, 2024 12:17
@saadyousafarbi saadyousafarbi changed the title [WIP] feat: add email cadence setting for email notifications feat: add email cadence setting for email notifications Mar 19, 2024
Copy link
Contributor

@muhammadadeeltajamul muhammadadeeltajamul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit. Rest looks good

It would be better to create a copy of list and remove email_cadence. This will improve code readability. Indexing/Slicing makes it hard to read and interpret code.

@saadyousafarbi saadyousafarbi merged commit 0270809 into master Apr 15, 2024
68 checks passed
@saadyousafarbi saadyousafarbi deleted the saad/INF-1251 branch April 15, 2024 12:04
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants