-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: making lms.djangoapps.ccx AppConfig ready. #34220
feat: making lms.djangoapps.ccx AppConfig ready. #34220
Conversation
Thanks for the pull request, @alexjmpb! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Is there an issue associated with this PR somewhere? I'd like to know more about the circumstances that lead to its discovery. |
@pdpinch We use the CCX feature in the openedx instances of our organization, and noticed that the outline of the CCXs were not being updated. This issue began after a migration from Juniper to Olive, and we started to debug why this was occurring. After some testings, we found that the task that updates the outline for each CCX (lms.djangoapps.ccx.send_ccx_course_published) was not being called, this was happening due to the issue with the course_published signal commented in the PR description. I then tested this issues in master and found that it's still present. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@alexjmpb I think this is ready to merge after you fix the quality issue. |
@alexjmpb 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Thanks @alexjmpb. I hope you don't mind, but I squashed your commits when I merged them. I should have asked you to do this, but I didn't want to add another day or two to this. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
…)" This reverts commit e7f02fe.
2U Release Notice: This PR has been deployed to the edX production environment. |
No worries at all. I was thinking of doing the same. Thanks for merging. |
Description
The CCX app uses a signal receiver (lms.djangoapps.ccx.course_published_handler) to know whenever the outline of a course is updated, the receiver listens to the signal "course_published". Right now, the lms.djangoapps.ccx app does not count with an AppConfig module to import the receivers, and the course_published signal can't be aware of them. This causes an unexpected behavior where the outline of the CCX is not updated. This PR aims to add an apps.py module containing an AppConfig class that imports the signal receivers of the app.
Useful information to include:
Testing instructions
It will suffice to add the settings stated in there to enable all features.