fix: Do NOT skip validating intentions which have NO related catalog queries #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
force-pushed
the
pwnage101/ENT-9941-4
branch
from
44f416f to
1fa70af
Compare
…queries When testing in prod, I found that Verizon Skills Forward was skipped because it only had a custom/curated catalog (catalog query was NULL). Greatest() in MySQL returns NULL if any input is NULL (unlike PostgreSQL), so adding Coalesce() with an arbitrarily old date is necessary to mimic the PostgreSQL behavior. ENT-9941
pwnage101
force-pushed
the
pwnage101/ENT-9941-4
branch
from
1fa70af to
c771e68
Compare
iloveagent57
approved these changes
Feb 3, 2025
adamstankiewicz
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing in prod, I found that Verizon Skills Forward was skipped because it only had a custom/curated catalog (catalog query was NULL). Greatest() in MySQL returns NULL if any input is NULL (unlike PostgreSQL), so adding Coalesce() with an arbitrarily old date is necessary to mimic the PostgreSQL behavior.
ENT-9941