-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for pathway retirement #4575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ADR wise, LGTM. Not approving it yet since you mentioned you're working on the code changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please update/add tests
- Update PR title and description
The ADR and changes seem reasonable to me. Question: Did this change need to be presented as a proposal to Product at Axim or the Product working group for Open edX? |
this seems sensible to me. re: @justinhynes's quetion: I'm not sure if Axim would feel anything going into course discovery (except breaking changes) would require going through the product WG, since the plan is to deprecate course-discovery, I believe. (#4449) That being said, I have mixed feelings over whether or not this constitutes a breaking change. Arguably if we coordinate the rollout of all of the different changes (e.g. course-discovery, credentials, etc.) it's all just internals, but the "arguably" is doing a lot of work there. tl;dr I agree that it's worth clearing this through product review. |
I don't think we need anything from Axim on this, especially after the deprecation. I don't think this is a breaking change. If we were only sending the published pathways from API after this change, that would have constituted the breaking change. However, as Ali Nawaz added in ADR, we have added the filter capability in API and then leaving it to consumers to handle it as they see fit. |
b8f2678
to
6803e86
Compare
PROD-2973
This PR:-