Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for pathway retirement #4575

Merged
merged 6 commits into from
Feb 24, 2025

Conversation

zawan-ila
Copy link
Contributor

@zawan-ila zawan-ila commented Feb 17, 2025

PROD-2973

This PR:-

  • Adds the ADR for pathways retirement
  • Adds the status field to Pathway objects
  • Exposes the status field in the Pathway APIs
  • Allows filtering the pathway api by status

Copy link
Contributor

@AfaqShuaib09 AfaqShuaib09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ADR wise, LGTM. Not approving it yet since you mentioned you're working on the code changes

Copy link
Contributor

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please update/add tests
  • Update PR title and description

@zawan-ila zawan-ila changed the title docs: add ADR for pathway retirement feat: add support for pathway retirement Feb 18, 2025
@justinhynes
Copy link
Contributor

justinhynes commented Feb 18, 2025

The ADR and changes seem reasonable to me.

Question: Did this change need to be presented as a proposal to Product at Axim or the Product working group for Open edX?

@deborahgu
Copy link
Member

this seems sensible to me.

re: @justinhynes's quetion: I'm not sure if Axim would feel anything going into course discovery (except breaking changes) would require going through the product WG, since the plan is to deprecate course-discovery, I believe. (#4449) That being said, I have mixed feelings over whether or not this constitutes a breaking change. Arguably if we coordinate the rollout of all of the different changes (e.g. course-discovery, credentials, etc.) it's all just internals, but the "arguably" is doing a lot of work there. tl;dr I agree that it's worth clearing this through product review.

@DawoudSheraz
Copy link
Contributor

this seems sensible to me.

re: @justinhynes's quetion: I'm not sure if Axim would feel anything going into course discovery (except breaking changes) would require going through the product WG, since the plan is to deprecate course-discovery, I believe. (#4449) That being said, I have mixed feelings over whether or not this constitutes a breaking change. Arguably if we coordinate the rollout of all of the different changes (e.g. course-discovery, credentials, etc.) it's all just internals, but the "arguably" is doing a lot of work there. tl;dr I agree that it's worth clearing this through product review.

I don't think we need anything from Axim on this, especially after the deprecation. I don't think this is a breaking change. If we were only sending the published pathways from API after this change, that would have constituted the breaking change. However, as Ali Nawaz added in ADR, we have added the filter capability in API and then leaving it to consumers to handle it as they see fit.

@zawan-ila zawan-ila merged commit 7ae2b3b into openedx:master Feb 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants