test: add a JS unit test to verify filterSubVerticals #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4296
branch
3 times, most recently
from
87dd832 to
e4f966c
Compare
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4296
branch
5 times, most recently
from
71d27e9 to
0249489
Compare
AfaqShuaib09
approved these changes
Feb 4, 2025
AfaqShuaib09
reviewed
Feb 4, 2025
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4296
branch
2 times, most recently
from
a3d2d8b to
5a11233
Compare
zawan-ila
reviewed
Feb 4, 2025
| super().setUpClass() | ||
| firefox_options = Options() | ||
| firefox_options.headless = True | ||
| cls.driver = webdriver.Firefox(options=firefox_options) |
There was a problem hiding this comment.
Isn't it the same?
There was a problem hiding this comment.
Just saying that cls.browser seems like a better name than cls.driver
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4296
branch
6 times, most recently
from
4dd8e07 to
1b164dc
Compare
zawan-ila
reviewed
Feb 10, 2025
Ali-D-Akbar
force-pushed
the
aakbar/PROD-4296
branch
from
1b164dc to
30ae0ad
Compare
zawan-ila
approved these changes
Feb 11, 2025
AfaqShuaib09
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-4296
Adds selenium-based unit tests to verify JS script added to load subverticals on the course tagging detail page.