fix: set legal and internal review to publish during CSVLoader

openedx · Dec 9, 2024 · bf2260b · bf2260b
1 parent c4599d9
commit bf2260b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/course_discovery/apps/course_metadata/data_loaders/csv_loader.py b/course_discovery/apps/course_metadata/data_loaders/csv_loader.py
@@ -268,7 +268,8 @@ def ingest(self):  # pylint: disable=too-many-statements
 
             course_run.refresh_from_db()
 
-            if course_run.status in [CourseRunStatus.Unpublished, CourseRunStatus.LegalReview]:
+            if course_run.status in [CourseRunStatus.Unpublished, CourseRunStatus.LegalReview,
+                                     CourseRunStatus.InternalReview]:
                 if course_run.status == CourseRunStatus.Unpublished:
                     # Pushing the run into LegalReview is necessary to ensure that the
                     # url slug is correctly generated in subdirectory format

diff --git a/course_discovery/apps/course_metadata/data_loaders/tests/test_csv_loader.py b/course_discovery/apps/course_metadata/data_loaders/tests/test_csv_loader.py
@@ -724,8 +724,9 @@ def test_ingest_flow_for_preexisting_unpublished_course(self, jwt_decode_patch):
                     )
 
     @responses.activate
-    def test_ingest_flow_for_preexisting_course_having_run_in_legal_review_status(
-        self, jwt_decode_patch
+    @data(CourseRunStatus.LegalReview, CourseRunStatus.InternalReview)
+    def test_ingest_flow_for_preexisting_course_having_run_in_review_statuses(
+        self, status, jwt_decode_patch
     ):  # pylint: disable=unused-argument
         """
         Verify that the course run will be reviewed if csv loader updates data for a course having a run in legal
@@ -744,7 +745,7 @@ def test_ingest_flow_for_preexisting_course_having_run_in_legal_review_status(
             course=course,
             key=self.COURSE_RUN_KEY,
             type=self.course_run_type,
-            status=CourseRunStatus.LegalReview,
+            status=status,
             go_live_date=datetime.datetime.now(UTC) - datetime.timedelta(days=5),
             draft=True,
             fixed_price_usd=111.11