-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adds release branch in catalog-info #278
base: master
Are you sure you want to change the base?
fix: Adds release branch in catalog-info #278
Conversation
Signed-off-by: Farhaan Bukhsh <[email protected]>
Thanks for the pull request, @farhaanbukhsh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
@feanil Please, can you review this PR :) thanks a lot in advance. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #278 +/- ##
=======================================
Coverage 55.35% 55.35%
=======================================
Files 3 3
Lines 56 56
=======================================
Hits 31 31
Misses 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@farhaanbukhsh why do we need to tag this repo for releases? We normally don't tag libraries that are getting pulled into the release via a tagged repo, in this case edx-platform. |
Hey @feanil I am sorry I don't have much knowledge about which repos we tag and which we don't so I would be happy if you could point to any discussion or document where I can learn more about it. I had a brief discussion with Sarina on openedx/axim-engineering#1338 (comment) which led to the two PRs I am open to learning more about this process so that I don't cause more trouble :) |
Description
This PR adds the key to catalog-info so that we can tag a release automatically next time.