This repository has been archived by the owner on May 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 335
fix: Add Alert Dialog in case of missing SKU on Store #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added an alert in case course sku doesn't exist on PlayConsole -LEARNER-9845
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1847 +/- ##
===========================================
- Coverage 1.07% 1.07% -0.01%
Complexity 137 137
===========================================
Files 538 538
Lines 26313 26340 +27
Branches 3391 3399 +8
===========================================
Hits 284 284
- Misses 26002 26029 +27
Partials 27 27 ☔ View full report in Codecov by Sentry. |
HamzaIsrar12
suggested changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual Review:
- I’m getting
Payments: Course Upgrade Error
segment analytic instead ofPayments: Price Load Error
. - We need to verify the flow from Access Expired and Course content case as well.
OpenEdXMobile/src/main/java/org/edx/mobile/view/dialog/CourseModalDialogFragment.kt
Outdated
Show resolved
Hide resolved
OpenEdXMobile/src/main/java/org/edx/mobile/viewModel/InAppPurchasesViewModel.kt
Outdated
Show resolved
Hide resolved
-LEARNER-9845
HamzaIsrar12
suggested changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add a value for the new case in
getFormattedErrorMessage
. - Do we need to hide the upgrade button in Course Component or Access Expired case if sku is not available on store?
OpenEdXMobile/src/main/java/org/edx/mobile/wrapper/InAppPurchasesDialog.kt
Show resolved
Hide resolved
HamzaIsrar12
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEARNER-9845