Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

fix: Add Alert Dialog in case of missing SKU on Store #1847

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

omerhabib26
Copy link
Contributor

Description

LEARNER-9845

  • Added an alert in case of course SKU doesn't exist on PlayConsole

- Added an alert in case course sku doesn't exist on PlayConsole

-LEARNER-9845
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Comparison is base (a6b4bac) 1.07% compared to head (b79d967) 1.07%.
Report is 2 commits behind head on master.

Files Patch % Lines
...rg/edx/mobile/viewModel/InAppPurchasesViewModel.kt 0.00% 16 Missing ⚠️
...ava/org/edx/mobile/wrapper/InAppPurchasesDialog.kt 0.00% 9 Missing ⚠️
...e/src/main/java/org/edx/mobile/util/TextUtils.java 0.00% 8 Missing ⚠️
...main/java/org/edx/mobile/exception/ErrorMessage.kt 0.00% 7 Missing ⚠️
...dx/mobile/view/dialog/CourseModalDialogFragment.kt 0.00% 2 Missing ⚠️
...in/java/org/edx/mobile/util/InAppPurchasesUtils.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1847      +/-   ##
===========================================
- Coverage      1.07%   1.07%   -0.01%     
  Complexity      137     137              
===========================================
  Files           538     538              
  Lines         26313   26340      +27     
  Branches       3391    3399       +8     
===========================================
  Hits            284     284              
- Misses        26002   26029      +27     
  Partials         27      27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual Review:

  • I’m getting Payments: Course Upgrade Error segment analytic instead of Payments: Price Load Error.
  • We need to verify the flow from Access Expired and Course content case as well.

Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add a value for the new case in getFormattedErrorMessage.
  • Do we need to hide the upgrade button in Course Component or Access Expired case if sku is not available on store?

Copy link
Contributor

@HamzaIsrar12 HamzaIsrar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@omerhabib26 omerhabib26 merged commit e0a44da into master Feb 21, 2024
4 checks passed
@omerhabib26 omerhabib26 deleted the omer/LEARNER-9845 branch February 21, 2024 07:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants