Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #587 #592 #601

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Cherry pick #587 #592 #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d067e5
feat(helm chart): add timeout for csi attacher and remove command fro…
Abhinandan-Purkait Dec 12, 2024
acb0cfb
feat(helm chart): add value to modify ps retries
Abhinandan-Purkait Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions chart/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ This removes all the Kubernetes components associated with the chart and deletes
| io_engine.​nvme.​ioTimeout | Timeout for IOs The default here is exaggerated for local disks, but we've observed that in shared virtual environments having a higher timeout value is beneficial. Please adjust this according to your hardware and needs. | `"110s"` |
| io_engine.​nvme.​tcp.​maxQueueDepth | You may need to increase this for a higher outstanding IOs per volume | `"32"` |
| io_engine.​priorityClassName | Set PriorityClass, overrides global | `""` |
| io_engine.​pstorRetries | Number of retries for pstor persistence before the volume target self shutdowns | `300` |
| io_engine.​resources.​limits.​cpu | Cpu limits for the io-engine | `""` |
| io_engine.​resources.​limits.​hugepages2Mi | Hugepage size available on the nodes | `"2Gi"` |
| io_engine.​resources.​limits.​memory | Memory limits for the io-engine | `"1Gi"` |
Expand Down
1 change: 1 addition & 0 deletions chart/templates/mayastor/csi/csi-controller-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ spec:
image: "{{ .Values.csi.image.registry }}/{{ .Values.csi.image.repo }}/csi-attacher:{{ .Values.csi.image.attacherTag }}"
args:
- "--v=2"
- "--timeout=36s"
- "--csi-address=$(ADDRESS)"
env:
- name: ADDRESS
Expand Down
2 changes: 0 additions & 2 deletions chart/templates/mayastor/csi/csi-node-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,6 @@ spec:
{{- end }}
- "--fmt-style={{ include "logFormat" . }}"
- "--ansi-colors={{ .Values.base.logging.color }}"
command:
- csi-node
volumeMounts:
- name: device
mountPath: /dev
Expand Down
1 change: 1 addition & 0 deletions chart/templates/mayastor/io/io-engine-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ spec:
- "--reactor-freeze-detection"{{ end }}
- "--tgt-crdt={{ .Values.io_engine.target.nvmf.hostCmdRetryDelay.crdt1 }}"{{ if .Values.eventing.enabled }}
- "--events-url=nats://{{ .Release.Name }}-nats:4222"{{ end }}
- "--ps-retries={{ default 300 .Values.io_engine.pstorRetries }}"
command:
- io-engine
securityContext:
Expand Down
2 changes: 2 additions & 0 deletions chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,8 @@ io_engine:
priorityClassName: ""
# -- Runtime class to use. Defaults to cluster standard
runtimeClassName: ""
# -- Number of retries for pstor persistence before the volume target self shutdowns
pstorRetries: 300
Abhinandan-Purkait marked this conversation as resolved.
Show resolved Hide resolved

etcd:
# -- Disable when using an external etcd cluster.
Expand Down
Loading