Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable new ci and build.yml changes #338

Merged
merged 2 commits into from
Oct 7, 2024
Merged

ci: enable new ci and build.yml changes #338

merged 2 commits into from
Oct 7, 2024

Conversation

dsharma-dc
Copy link
Contributor

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:

What this PR does?:

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@dsharma-dc dsharma-dc force-pushed the ci_remaining branch 4 times, most recently from b6deddc to 000e5e8 Compare September 27, 2024 06:02
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is tagged release handled?

@dsharma-dc
Copy link
Contributor Author

How is tagged release handled?

That's in #340 if that's what you are asking.

@dsharma-dc dsharma-dc force-pushed the ci_remaining branch 2 times, most recently from b1958b9 to e6b8b78 Compare September 30, 2024 06:39
@dsharma-dc dsharma-dc force-pushed the ci_remaining branch 3 times, most recently from 83fb39d to 10a55a7 Compare October 4, 2024 05:53
@dsharma-dc
Copy link
Contributor Author

@Abhinandan-Purkait I see a very strange thing, that the output of below command that we have in workflow files varies between zfs vs lvm repos.

awk -F': ' '/^version:/ {print $$2}' deploy/helm/charts/Chart.yaml

In zfs, it correctly returns e.g. 2.7.0-develop. In lvm it is returning the first field i.e. the string version ! I don't see any difference in Chart.yaml formattting. Using single $ in print works correctly. I will change this to use single $ as I think it's just a typo that there are two $$ inadvertently.

@dsharma-dc dsharma-dc merged commit 8a7e84c into develop Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants