test(volgroup_vgpattern_bdd): adding feature file #313
Conversation
abhilashshetty04
requested review from
tiagolobocastro,
avishnu,
Abhinandan-Purkait,
niladrih and
dsharma-dc
| Given a sc is created with volgroup as "lvmvg" | ||
| And pvc is created referencing the same sc | ||
| Then lvmvolume cr should get created | ||
| And cr state should be Ready |
There was a problem hiding this comment.
Is it worth using some application or it's maybe fine as this focuses on the vg configs.
There was a problem hiding this comment.
This just focuses on scheduling. However, I have added one case for testing WairForFirstConsumer. That will require a pod.
|
|
||
| Scenario: test sc with volgroup present on the node | ||
| Given a sc is created with volgroup as "lvmvg" | ||
| And pvc is created referencing the same sc |
There was a problem hiding this comment.
let's use full forms of these abbreviations throughout sc -> storage class , cr -> custom resource, pvc -> volume
There was a problem hiding this comment.
Okay....will keep pvc as is, making it volume might not be clearly referencing it to pvc.
There was a problem hiding this comment.
On the second thought, These all are k8s recognised shortforms. Could be okay to keep all as is??
There was a problem hiding this comment.
yeah, but bdds are kind of generic and not k8s specific. You can refer maybe Mayastor bdds, if they use similar terminology, let's keep that.
| Given "lvmvg" has lesser free space then "lvmvg1" | ||
| And sc is created with volgroup as "lvmvg" | ||
| When a pvc is created with size higher then "lvmvg" and lower then "lvmvg1" free space | ||
| Then pvc should not be bound | ||
| And lvmvolume cr should not be created |
There was a problem hiding this comment.
The mention of lvmvg1 is irrelevant here since sc will mention lvmvg and pvc just needs to be larger than free space on lvmvg
There was a problem hiding this comment.
I wanted to emphasize that there is another vg on the node which would not match pattern but has more free space to accomodate the pvc requested size..
There was a problem hiding this comment.
I have changed it a little. Please check.
|
|
||
| Scenario: test sc with volgroup present on the node | ||
| Given a sc is created with volgroup as "lvmvg" | ||
| And pvc is created referencing the same sc |
There was a problem hiding this comment.
yeah, but bdds are kind of generic and not k8s specific. You can refer maybe Mayastor bdds, if they use similar terminology, let's keep that.
|
|
||
| Background: | ||
| Given a 3 node lvm localpv cluster is configured | ||
| And each node has vg named "lvmvg" |
There was a problem hiding this comment.
we'll keep this vg only on the node having custom label, and not on each node.
There was a problem hiding this comment.
Should that matter? Even if its on other nodes also, We will validate eventually lvmvolume schedules on expected node.
Signed-off-by: Abhilash Shetty <[email protected]>
abhilashshetty04
force-pushed
the
volgroup_vgpattern_bdd
branch
from
14c1a4c to
a5d6226
Compare
What this PR does?:
This PR includes bdd specification for volgroup and vgpattern based test
Does this PR require any upgrade changes?:
NA
If the changes in this PR are manually verified, list down the scenarios covered::
NA