Merge pull request #526 from openeemeter/normalize-warning-name-acros…

…s-data-models Ensures the model.warnings/model.disqualification fields exist across both models
opendsm · Jan 6, 2025 · a2ca76b · a2ca76b
2 parents bec797d + 9f9e1f0
commit a2ca76b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@ Changelog
 Development
 -----------
 
+* Rename HourlyBaselineData.sufficiency_warnings -> HourlyBaselineData.warnings
+* Add disqualification field to HourlyBaselineData and HourlyReportingData
 * Fix bug where HourlyBaselineData and HourlyReportingData wasn't actually NaNning zero rows when `is_electricity=True`.
 * Constrain eemeter daily model balance points to T_min_seg and T_max_seg rather than T_min and T_max.
 

diff --git a/eemeter/eemeter/models/hourly/data.py b/eemeter/eemeter/models/hourly/data.py
@@ -38,6 +38,8 @@ def __init__(self, df: pd.DataFrame, is_electricity_data: bool):
         df = self._correct_frequency(df)
 
         self.df = df
+        self.warnings = []
+        self.disqualification = []
 
     def _correct_frequency(self, df: pd.DataFrame):
         meter = df["observed"]
@@ -90,7 +92,8 @@ def __init__(self, df: pd.DataFrame, is_electricity_data: bool):
         df = self._correct_frequency(df)
 
         self.df = df
-        self.sufficiency_warnings = self._check_data_sufficiency()
+        self.warnings = self._check_data_sufficiency()
+        self.disqualification = []
 
     def _check_data_sufficiency(self):
         meter = self.df["observed"].rename("meter_value")