Do not error when no matching pipeline can be found #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning an error does not seem appropriate because there can be situations in which no pipeline should match which are "expected". For example, one might configure to act on PR comments of "/deploy", but for all other PR comment (events), nothing should happen. The log will still report that there was no matching pipeline so that users can figure out what is going on. The issue was introduced in #685. Since that has not been released yet, the bugfix will not be recorded in the changelog.
michaelsauter
force-pushed
the
fix/non-matching-pipeline-error
branch
from
dc8e614 to
b830778
Compare
michaelsauter
commented
May 12, 2023
| @@ -142,6 +142,8 @@ The following selection criteria may be specified: | |||
| `exceptTags`:: List of tags to which the triggering event may not refer. Patterns as supported by link:https://pkg.go.dev/path#Match[`path.Match`] may be used to match the excluded tags. Omitting the criterion will lead to none of the tags referred to in the webhook event to be excluded. | |||
| `prComment`:: Define a prefix a comment has to start with. Might be used to implement functionality like slash commands. If omitted, comments won't be considered in the pipeline selection process. | |||
|
|
|||
| CAUTION: link:https://pkg.go.dev/path#Match[`path.Match`] does not match e.g. `feature/foo` when the pattern is just `\*`. If you want to match strings with slashes, specify the pattern `*/\*` as well. For example, to match all branches, write `branches: ["*", "\*/*"]`. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning an error does not seem appropriate because there can be situations in which no pipeline should match which are "expected". For example, one might configure to act on PR comments of "/deploy", but for all other PR comment (events), nothing should happen.
The log will still report that there was no matching pipeline so that users can figure out what is going on.
The issue was introduced in #685. Since that has not been released yet, the bugfix will not be recorded in the changelog.
Tasks:
docs/designdirectory or not applicabledocsdirectory or not applicablemake test) or not applicable