Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stack-based Buffer Overflow on protobuf #44

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

spolti
Copy link
Member

@spolti spolti commented Jan 12, 2024

chore: Fix Stack-based Buffer Overflow on protobuf on protobuf

Motivation

Modifications

Result

@spolti spolti requested review from Jooho and israel-hdez January 12, 2024 17:58
@openshift-ci openshift-ci bot requested a review from vaibhavjainwiz January 12, 2024 17:58
Copy link

openshift-ci bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jooho
Copy link

Jooho commented Jan 15, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d4c120f into opendatahub-io:main Jan 15, 2024
10 checks passed
@spolti spolti deleted the RHOAIENG-1730 branch January 15, 2024 17:37
Jooho pushed a commit to Jooho/modelmesh-runtime-adapter that referenced this pull request May 21, 2024
Currently, pull requests get auto-assigned `reviewers` (and `approvers`) by the @kserve-oss-bot
However, many of the reviewers and approvers are no longer active. When inactive reviewers are auto-assigned, then active contributors who could actually help with reviews are not notified about new PRs.

Similarly, the @kserve-oss-bot adds a message to PRs about who is allowed to approve PRs, which often points to inactive contributors.

- Following [Kubernetes guidance](https://www.kubernetes.dev/docs/guide/owners/#cleanup), moving inactive `approvers` under `emeritus_approvers`, removing inactive contributors from list of `reviewers`
- Adding currently active contributors to the list of `reviewers`
- Removing `reviewers` who are no longer working on the project

An updated OWNERS file. Auto-assigned reviewers are currently active.

- [ ] kserve/modelmesh#89
- [ ] kserve#44
- [ ] kserve/modelmesh-serving#354

Signed-off-by: Christian Kadner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants