Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync community with odh #40

Closed
wants to merge 3 commits into from
Closed

Sync community with odh #40

wants to merge 3 commits into from

Conversation

spolti
Copy link
Member

@spolti spolti commented Dec 12, 2023

Motivation

Modifications

Result

- Remove the linters for "deadcode", "structcheck", "varcheck"
- Use "os" packages instead of deprecated "io/ioutil" (SA1019)
- Capture pre-commit output in a local log file

Fixes opendatahub-io#64

---------

Signed-off-by: Spolti <[email protected]>
- elazarl/goproxy [CVE-2023-37788] Denial of Service (DoS)
- emicklei/go-restful [CVE-2022-1996] Authorization Bypass Through User-Controlled Key
- prometheus/client_golang [CWE-400] Denial of Service (DoS)

-----

Signed-off-by: Spolti <[email protected]>
Copy link

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@israel-hdez
Copy link

@spolti I wonder if you would prefer to use puller PRs. As long as there are no conflicts, you would be relieved from doing this manually.

There is already one opened: #39. You can approve your own changes, which is OK since upstream already reviewed and approved.

@israel-hdez
Copy link

...it also saves us from seeing two merge commits in history.

@spolti
Copy link
Member Author

spolti commented Dec 13, 2023

didn't notice it, let's use the other PR then :)

@spolti spolti closed this Dec 13, 2023
@spolti spolti deleted the sync branch October 1, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants