Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from kubeflow:main #152

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Dec 4, 2024

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

)

* feat(bff): use 'kubeflow-userid' header to authorize BFF endpoints

Signed-off-by: Eder Ignatowicz <[email protected]>

* fixing lint

Signed-off-by: Eder Ignatowicz <[email protected]>

---------

Signed-off-by: Eder Ignatowicz <[email protected]>
Copy link

openshift-ci bot commented Dec 4, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.49%. Comparing base (5c54df5) to head (ea1afd2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
- Coverage   72.54%   72.49%   -0.06%     
==========================================
  Files          25       25              
  Lines        2739     2752      +13     
  Branches       73       73              
==========================================
+ Hits         1987     1995       +8     
- Misses        540      544       +4     
- Partials      212      213       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…#596)

Signed-off-by: Jenny <[email protected]>

remove unused components

apply font color and border to selected nav items

remove unused vars

Signed-off-by: Jenny <[email protected]>

format and remove unused imports

Signed-off-by: Jenny <[email protected]>

fix a11y issues

Signed-off-by: Jenny <[email protected]>

add navbar

Signed-off-by: Jenny <[email protected]>

temporarily revert fix to force a11y error in GH actions

Signed-off-by: Jenny <[email protected]>

revert color back to fix a11y error

Signed-off-by: Jenny <[email protected]>

remove hover color on brand image
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

openshift-ci bot commented Dec 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pull[bot], tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit be1d318 into opendatahub-io:main Dec 8, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants