Site maintenance etc. #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdolitsky
requested review from
SteveLasker,
sudo-bmitch,
tianon,
vbatts and
vsoch
as code owners
✅ Deploy Preview for oci-conformance ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jdolitsky
force-pushed
the
maintenance
branch
6 times, most recently
from
65de304 to
df3fd11
Compare
Signed-off-by: Josh Dolitsky <[email protected]>
sudo-bmitch
approved these changes
Aug 7, 2024
Comment on lines
+5
to
+6
| // See https://github.com/darccio/mergo#important-notes | ||
| replace github.com/imdario/mergo => github.com/imdario/mergo v0.3.16 |
There was a problem hiding this comment.
This seems like a sign we'd want to either update our code or swap out the dependency.
Comment on lines
+3
to
+5
| # build-static-site.sh | ||
| # Generates a static HTML site into _site/ | ||
| # Requires Go ...and Ruby |
There was a problem hiding this comment.
I think it would be useful to make this available to run with a docker container (e.g. with a make serve command that does a docker build / docker run) for developers to test locally.
This was referenced Aug 7, 2024
|
@sudo-bmitch - I converted your two comments into issues:
Will go ahead and merge this since it gets us into a better spot |
gursoy741
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./hack/build-static-site.sh