Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support icmp type for acl #491

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Support icmp type for acl #491

merged 2 commits into from
Oct 28, 2024

Conversation

DanG100
Copy link
Collaborator

@DanG100 DanG100 commented Oct 28, 2024

No description provided.

@DanG100 DanG100 requested a review from guoshiuan October 28, 2024 20:25
@github-actions GitHub Actions
Copy link

Pull Request Test Coverage Report for Build 11562057146

Details

  • 2 of 8 (25.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.001%) to 2.877%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dataplane/saiserver/acl.go 2 8 25.0%
Files with Coverage Reduction New Missed Lines %
dataplane/forwarding/fwdport/ports/group.go 1 67.78%
dataplane/standalone/pkthandler/pktiohandler/pktiohandler.go 8 44.74%
Totals Coverage Status
Change from base Build 11522641507: 0.001%
Covered Lines: 18947
Relevant Lines: 658678
💛 - Coveralls

guoshiuan
guoshiuan approved these changes Oct 28, 2024
View reviewed changes
dataplane/saiserver/acl.go Show resolved Hide resolved
@DanG100 DanG100 merged commit f81ef11 into main Oct 28, 2024
9 of 11 checks passed
@DanG100 DanG100 deleted the acl2 branch October 28, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshiuan guoshiuan guoshiuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanG100 @guoshiuan