Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootz.proto #125

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Update bootz.proto #125

merged 1 commit into from
Feb 7, 2024

Conversation

marcushines
Copy link
Contributor

Change package name to be correct

Change package name to be correct
Copy link

Pull Request Test Coverage Report for Build 7494249796

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.281%

Totals Coverage Status
Change from base Build 7393381670: 0.0%
Covered Lines: 343
Relevant Lines: 569

💛 - Coveralls

@marcushines marcushines requested a review from xw-g February 7, 2024 16:52
@xw-g xw-g merged commit 5330e6e into main Feb 7, 2024
9 checks passed
@gmacf
Copy link
Contributor

gmacf commented Feb 8, 2024

What's the reason for this change?

This is going to break Bootz as it will change the gRPC service name exported by the server. The software versions used by our test devices will contain the old gRPC service name and won't be able to communicate.

@marcushines marcushines deleted the marcushines-patch-1 branch February 14, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants