-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SetLink to the list #2814
Add SetLink to the list #2814
Conversation
@tanksha, I think it would be more appropriate to be grouped with that code atomspace/opencog/atoms/core/Checkers.cc Lines 65 to 69 in 7ae6984
since |
Nil, The meta-issue is that none of these link types are actually "evaluatable" in Atomese. Here's the problem: in the early days of "Atomese", at Hanson Robotics, there was a need to So now you see what the problem is -- if you call There are 3-4 different solutions:
I'll open a new issue to continue this discussion, we shouldn't have it here... See #2816 |
I, BTW, would have no problem introducing |
So -- |
Hmm. As I attempt to think about #2816, I realize that perhaps |
@ngeiswei I have made the suggested changes, please check. |
Where are we at with this? It seems that whatever needed this, it was not urgent. May I close this? |
I think @tanksha 's change is correct for the time being. The better longer term change could be to introduce However it's failing circleci. @tanksha, could you rebase your branch (oh, it's your master branch, you should use another one) onto the opencog/master? |
@tanksha, I think you need to close that PR and create a new one (adding a reference to that one cause it discusses important matters) with a new branch. |
That other option is to just close that PR and forget about it, but I believe the bio-atomspace relies on that change. |
Pull req #2843 adds UnionLink. I plan to merge it as soon as it passes unit tests. I still think that experimenting with novel kinds of truth values is worthwhile: e.g. having a |
Just hit "retest" I don't think you have to rebase. |
I believe we can safely close that issue now. |
This will make creating patterns like (Not (Set A)) possible, in working with singletons.