All search functions now use QueueValue for results. #2571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2020
linas
added a commit
to opencog/attention
that referenced
this pull request
May 5, 2020
Requiered by poll req opencog/atomspace#2571
linas
added a commit
to opencog/miner
that referenced
this pull request
May 5, 2020
Remove after opencog/miner#40 is merged ...
ngeiswei
added a commit
to opencog/miner
that referenced
this pull request
May 5, 2020
Required API change for pull opencog/atomspace#2571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull req modifies all of the search functions to use the
new
QueueValue(#2569) to pass search results around.This partly addresses concerns in issues #2530 and #1502
In principle, this allows queries to run in one (or more) threads,
while other threads process the queries as they arrive. Nothing
actually does this yet, but the possibility is now there.