Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the release action #110

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fix the release action #110

merged 1 commit into from
Nov 25, 2024

Conversation

cdiener
Copy link
Member

@cdiener cdiener commented Nov 25, 2024

This fixes a bug introduced in #104 . Packages are now taken from the correct directory. Unfortunately, can only be tested with an actual release.

Midnighter
Midnighter approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! You should be able to "test" by making a pre-release like 1.2.3a1.

@cdiener cdiener merged commit f317528 into master Nov 25, 2024
5 checks passed
@cdiener cdiener deleted the fix/release branch November 25, 2024 12:45
@cdiener
Copy link
Member Author

cdiener commented Nov 25, 2024 •
edited
Loading

The alpha release does not seem to work. Does not get picked up by the CD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Midnighter Midnighter Midnighter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdiener @Midnighter