Fix the GLPK build on Windows for setuptools>74.0 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Midnighter
reviewed
Oct 28, 2024
|
@Midnighter Have a look now. |
Midnighter
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Starting from setuptools 74.0 setuptools has removed the deprecated MSVC toolchain. We did not actually use that to compile any Python packages, but we did use it to setup the compilation environment for building GLPK. Some functionality was restored into setuptool via
setuptools.msvc.EnvironmentInfobut thereturn_envfunction there did not work as it is missing some env variables, most importantly the ones pointing towards the C standard lib which glpk needs.Solution
As far as i can tell there is no way to setup the env with Python libraries anymore. The alternative is the good ol'
vcvarsall.batwhich is notoriously hard to locate in a MSVC install but will lead to a working environment. This PR adds a function to look for it with an initial guess that is the current location in Github Actions and a somehwat future-proof fallback that will simply go digging for it.Backwards compatibility
The new solution does not use setuptools at all so it works will any version.
Don't forget to squash before merge. It needed a lot of experiments.