Reformat probabilistic numbers in tooltip #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
peterdudfield
approved these changes
Nov 16, 2023
|
I wonder if the ttxt should be P90 and P10 not 90% and 10% as this is a bit more recognisable that this is a plevel |
|
hey @peterdudfield , Thanks for the feedback. I agree that the If there are no values for the plevels, it'll just return nothing. |
braddf
requested changes
Nov 23, 2023
There was a problem hiding this comment.
Couple of tiny things but then good to merge @rachel-labri-tipton, nice work 😊
braddf
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Updates the formatting for probabilistic numbers in the tooltip. This was discussed here: #384 .
The updated tooltip looks like this.
It might be noticeable that the
OCF Forecastis now in semi-bold because thetextClassapplied wasn't working, so I fixed that as well when I set thetextClassfor the P levels and values.I updated
useFormatChartDataso that it returns 3 probabilistic things:PROBABILISTIC_RANGEas an array for the area plotted on the chart and thenPROBABILISTIC_UPPER_BOUNDandPROBABILISTIC_LOWER_BOUNDas numbers. This seems repetitive, but when it came to the tooltip, it was easy to just have number values for all tooltip labels.In terms of review, would like to know if all tooltip numbers are still showing correctly.
Fixes #384
How Has This Been Tested?
I ran the code locally.
Checklist: