Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solar Sites UI MVP => nowcasting UI for individual pv site owners #338

Merged
merged 52 commits into from
Apr 6, 2023

Conversation

rachel-labri-tipton
Copy link
Contributor

@rachel-labri-tipton rachel-labri-tipton commented Feb 15, 2023

Solar Sites UI MVP

The work here responds to #323 that will be building the following feature:
Screenshot 2023-02-15 at 08 32 30

Like with #287, the delta view feature, we'll be working on the feat/323-solar-sites branch and using this PR to communicate about and review code as the work progresses. If it seems necessary to make branches off of this branch for some components, such as map features, then we shall do so.

Description

This is the individual PV site view that offers a UI to individual pv site owners with a specific pv forecast for each of their sites.

Builds #323

How Has This Been Tested?

Code will be tested by running it locally and inspecting UI/UX on the deployed Vercel branches.

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@vercel
Copy link

vercel bot commented Feb 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nowcasting-app ✅ Ready (Inspect) Visit Preview 11 resolved Apr 6, 2023 4:24pm
nowcasting-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2023 4:24pm


const SitesMapSlider: React.FC<{ selected?: string; unselected?: string }> = ({
const SitesMapSlider: React.FC<{ selected?: string; unselected?: string; event?: any }> = ({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @braddf, This is what I came up with for the initial "slider" for the map. Would be great to have feedback on the ranges for the zoom levels (line 13-22) and if this is sort of what you were thinking. I know it isn't a traditional "slider". I felt like keeping the look boxy fit with the design. When you click the +/- buttons, the highlighted view changes.

As you can see, I tried adding an event handler to each div, but Typescript seemed unhappy with the event.target situation when I pushed my code. That's why it's been deleted. Didn't seem like it was necessary for this commit.

Any other feedback, pointers are welcome.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - just making sure I've been through all these comments, sorry for the delay... we can take a look at this design on the next iteration when we finish the aggregation stuff; I have some ideas to make this a little less intrusive, but we'll have to play around and see what feels right 👍


const SitesMapSlider: React.FC<{ selected?: string; unselected?: string }> = ({
const SitesMapSlider: React.FC<{ selected?: string; unselected?: string; event?: any }> = ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - just making sure I've been through all these comments, sorry for the delay... we can take a look at this design on the next iteration when we finish the aggregation stuff; I have some ideas to make this a little less intrusive, but we'll have to play around and see what feels right 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants