Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix data loader #45

Merged
merged 1 commit into from
Jan 23, 2025
Merged

fix data loader #45

merged 1 commit into from
Jan 23, 2025

Conversation

jcamier
Copy link
Collaborator

@jcamier jcamier commented Jan 23, 2025

Pull Request

Issue #31

How Has This Been Tested?

  • Yes

Checklist:

  • [x ] My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@jcamier
Copy link
Collaborator Author

jcamier commented Jan 23, 2025

@Sukh-P here is a refactor that allows the dataset to contain the dimensions you wanted changed and to allow for remote/lazy loading of dataset.

@jcamier jcamier merged commit 6b0900f into main Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants