Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GFS Statistics to constants.py #145

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

siddharth7113
Copy link
Contributor

@siddharth7113 siddharth7113 commented Jan 23, 2025

Pull Request

Description

Added GFS mean and standard deviation (STD) values to constants.py for integration with the new repository. Enhanced the NWP_PROVIDERS list and NWPStatDict to include GFS support.

Key Changes:

  • Introduced GFS_MEAN and GFS_STD values, formatted using _to_data_array.
  • Updated NWP_PROVIDERS to include "gfs".
  • Extended NWP_MEANS and NWP_STDS in NWPStatDict to handle GFS data.
  • Maintained consistent structure and formatting with existing constants like UKV and ECMWF.

Checklist

- Integrated GFS mean and standard deviation (STD) values into `constants.py`.
- Added GFS to `NWP_PROVIDERS` list for better support of additional NWP models.
- Created `GFS_MEAN` and `GFS_STD` variables using `_to_data_array` for consistency.
- Updated `NWPStatDict` to include GFS-related constants in `NWP_MEANS` and `NWP_STDS`.
- Ensured structure and formatting align with existing UKV and ECMWF data.
@siddharth7113
Copy link
Contributor Author

@Sukh-P ,
@peterdudfield
Hi , I am working in open-data-pvnet which requeries working with gfs-data , Would it be possible to review the PR and merge it, if everything seems correct?

@Sukh-P
Copy link
Member

Sukh-P commented Jan 24, 2025

@siddharth7113 the code change looks good, just one thing to mention/look out for is that the value ranges of the data looks roughly equivalent after normalisation if you are using multiple NWP providers, I say this because the ECMWF normalisation constants for example have been calculated for the UK specifically, where as I am unsure whether the same has been done for the GFS constants (could have been done globally or for another region), I am going to create an issue/discussion as I think we may want to move to making the normalisation constants more specific for regions and then have some way of controlling which ones are used

@siddharth7113
Copy link
Contributor Author

@siddharth7113 the code change looks good, just one thing to mention/look out for is that the value ranges of the data looks roughly equivalent after normalisation if you are using multiple NWP providers, I say this because the ECMWF normalisation constants for example have been calculated for the UK specifically, where as I am unsure whether the same has been done for the GFS constants (could have been done globally or for another region), I am going to create an issue/discussion as I think we may want to move to making the normalisation constants more specific for regions and then have some way of controlling which ones are used

Yeah, it would be best to discuss them , I tried normalization using ecmwf here for some attributes and found some discripenacies, As for GFS values, I simply copied them from here

@Sukh-P Sukh-P merged commit bc43997 into openclimatefix:main Jan 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants