[FIX] partial fix for issue 386, prevent copy items in manage view of course #388
Conversation
|
I did test this fix. After selecting the the target course where the object should be copied to and hitting on "Paste" I get redirected back to the page I came from (in my case the course where the originals object is situated) and an error message is shown ("Permission Denied"). This is prevents from getting non-functional copies of Opencast objects but is far from optimal. I guess, that's why you write "partial fix" in the title. @chfsx: What kind of options to improve this behavior do we have? The easiest I could imagine would be to specify the "Permission Denied" message why copying is not possible. |
|
In meeting: Can not be optimized in the plugin. To fix we would need to create a bug report for the core but there is little chance that it will get fixed soon or even at any time. Next step: |
There was a problem hiding this comment.
Thanks, @chfsx, for your work!
Your solution works as expected and should be considered the definitive approach for now (until a fix from ILIAS Core is available) rather than a partial solution, in my opinion.
I have suggested two minor changes; please take a look.
Best regards.
| * @param string $a_user_id | ||
| */ | ||
| public function _checkAccess($a_cmd, $a_permission, $a_ref_id, $a_obj_id = null, $a_user_id = ''): bool | ||
|
|
There was a problem hiding this comment.
The extra line should be removed or even better, replace it with inheritDoc:
| /** | |
| * @inheritDoc | |
| */ |
| /** @var ObjectSettings $objectSettings */ | ||
| $objectSettings = ObjectSettings::find($a_obj_id); | ||
| if ($all_refs = $objectSettings->getDuplicatesOnSystem()) { | ||
| if ($objectSettings && $all_refs = $objectSettings->getDuplicatesOnSystem()) { |
There was a problem hiding this comment.
I would not recommend using a variable and fetching a variable in a same if statement, I would recommend doing it like:
| if ($objectSettings && $all_refs = $objectSettings->getDuplicatesOnSystem()) { | |
| $all_refs = $objectSettings ? $objectSettings->getDuplicatesOnSystem() : null; | |
| if (!empty($all_refs)) { |
This PR prevents copying objects in manage view of courses. The plugin itself already "defines" that copy should not be possible. ILIAS seems to ignore that, I tried to track this down in ILIAS Core but just found a lot of old code and was not able to find the right place where this should be checked in ILIAS. This PR provides a workaround: while checking permissions, the plugin now always returns
falsefor the copy-permission. this at least prevents from generating (non-functions) copies of Opencast objects in ILIAS.