OBPIH-6882: Fix for Export all items empty db case #30
Conversation
kkrawczyk123
changed the title
kkrawczyk123
changed the title
| await createInboundPage.addItemsStep.isLoaded(); | ||
| await createInboundPage.wizzardSteps.assertActiveStep('Add items'); | ||
|
|
||
| INBOUND2_ID = createInboundPage.getId(); |
There was a problem hiding this comment.
do you need to declare the INBOUND2_ID as a let? I don't see you are overriding this value, but maybe I am missing something
There was a problem hiding this comment.
Otherwise it'd need to be initialized in a different place, so I guess it is fine. Plus I see this is done like that in other places as well.
| const ifInboundListPageIsEmpty = | ||
| await inboundListPage.table.emptyInboundList.isVisible(); | ||
| const ifInboundListPageIsNotEmpty = | ||
| await inboundListPage.table.emptyInboundList.isHidden(); |
There was a problem hiding this comment.
why do you need both ifInboundListPageIsEmpty and ifInboundListPageIsNotEmpty?
For me, it looks like:
ifInboundListPageIsEmpty == !ifInboundListPageIsNotEmpty
kkrawczyk123
changed the title
| } | ||
|
|
||
| if (ifInboundListPageIsNotEmpty) { | ||
| await test.step('Go to create stock movement', async () => { |
There was a problem hiding this comment.
Everything in this if is a duplication of the part from lines 98-145. Can you just move this part out of the if above and remove this one? Or is there any kind of difference there?
| await createInboundPage.addItemsStep.isLoaded(); | ||
| await createInboundPage.wizzardSteps.assertActiveStep('Add items'); | ||
|
|
||
| INBOUND2_ID = createInboundPage.getId(); |
There was a problem hiding this comment.
Otherwise it'd need to be initialized in a different place, so I guess it is fine. Plus I see this is done like that in other places as well.
Added fix for issue described in https://pihemr.atlassian.net/browse/OBPIH-6882?focusedCommentId=157847