-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBPIH-6882: improve export all incoming items test #26
Conversation
@@ -9,6 +9,8 @@ test.describe('Export all incomming items', () => { | |||
test.afterEach(async ({ stockMovementService, stockMovementShowPage }) => { | |||
await stockMovementShowPage.goToPage(INBOUND_ID); | |||
await stockMovementShowPage.isLoaded(); | |||
await stockMovementShowPage.rollbackLastReceiptButton.click(); | |||
await stockMovementShowPage.rollbackLastReceiptButton.click(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it twice here? Is it expected? If yes, then please add a comment why it is done twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is expected because of partial receiving. 2 items are received in separate receipts so both need to be rolledbacked.
workbooks.push(downloadedTemplateFile); | ||
}); | ||
|
||
await test.step('Assert received items from stock movement are not included in the epxort file', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a separate test case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be split into 3 tests for asserting shipped, partially received and received inbound but as the original test was named 'Export all incomming items should include items shipped not received' I included all cases in 1 test.
@kkrawczyk123 looks like after pushing this PR the actions are running for 1h and are timeouted/failed. Could you take a look if there is some stale data on obdev3 that makes the test fail overall? |
@awalkowiak I don't know why it fails and if it has any connection to any data because it all works for me when I run tests manually on obdev3. |
I expanded export all incoming items test with tracking changes in the file when receiving items.