Add importImperial(), deprecate importKCL()
#411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added importImperial - warns on use of importKCL - importImperial has slightly different function args to match importUKAQ
jack-davison
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the awkwardness of
importKCL()!All references to "King's College London" have been renamed along the lines of "Imperial College London, formerly King's College London".
importImperial()has been added (in reality, a renamedimportKCL()). The opportunity has been taken to align its argument names withimportUKAQ()(e.g., met -> meteo).importKCL()still exists, and is passed toimportImperial()with a warning to useimportImperial()instead.importMeta()now takes"imperial", but"kcl"still works for back-compatibility.