Merge pull request #978 from aschnell/master

- use const ref as return type
openSUSE · Jan 7, 2025 · 7517f9a · 7517f9a
2 parents bf0fe2b + f255e77
commit 7517f9a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/client/snapper/GlobalOptions.h b/client/snapper/GlobalOptions.h
@@ -56,10 +56,10 @@ namespace snapper
 	Style table_style() const { return _table_style; }
 	bool abbreviate() const { return _abbreviate; }
 	OutputFormat output_format() const { return _output_format; }
-	string separator() const { return _separator; }
+	const string& separator() const { return _separator; }
 	bool headers() const { return _headers; }
-	string config() const { return _config; }
-	string root() const { return _root; }
+	const string& config() const { return _config; }
+	const string& root() const { return _root; }
 	Ambit ambit() const { return _ambit; }
 
 	void set_ambit(Ambit ambit) { _ambit = ambit; }

diff --git a/client/snbk/GlobalOptions.h b/client/snbk/GlobalOptions.h
@@ -50,7 +50,7 @@ namespace snapper
 	bool quiet() const { return _quiet; }
 	bool verbose() const { return _verbose; }
 	bool debug() const { return _debug; }
-	boost::optional<BackupConfig::TargetMode> target_mode() { return _target_mode; }
+	const boost::optional<BackupConfig::TargetMode>& target_mode() { return _target_mode; }
 	bool automatic() const { return _automatic; }
 	bool utc() const { return _utc; }
 	bool iso() const { return _iso; }
@@ -59,9 +59,9 @@ namespace snapper
 	bool help() const { return _help; }
 	Style table_style() const { return _table_style; }
 	OutputFormat output_format() const { return _output_format; }
-	string separator() const { return _separator; }
+	const string& separator() const { return _separator; }
 	bool headers() const { return _headers; }
-	boost::optional<string> backup_config() const { return _backup_config; }
+	const boost::optional<string>& backup_config() const { return _backup_config; }
 
     private: