fix(dracut): do not add all lib subdirs to LD_LIBRARY_PATH with --sysroot (bsc#1230354) (SLFO)
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sysroot` On systems with too many library subdirectories, the current approach causes `Argument list too long` errors, and the initrd also fails to build. This patch does not fix the original issue by itself (i.e., libsystemd libs not found), so all the dracut modules that require libraries stored in subdirectories must explicitly install them using `inst_libdir_file`, which already successfully handles the `--sysroot` prefix. Fixes dracut-ng/dracut-ng@e0b8768 Co-authored-by: Antonio Alvarez Feijoo <[email protected]> bsc#1230354 (cherry picked from commit dracut-ng/dracut-ng@d0c8232)
(cherry picked from commit dracut-ng/dracut-ng@921792f)
tblume
reviewed
Sep 12, 2024
Added some docs here: dracut-ng/dracut-ng#662 But I would not stop landing this fix waiting for that... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On systems with too many library subdirectories, the current approach causes
Argument list too long errors, and the initrd also fails to build.This patch does not fix the original issue by itself (i.e., libsystemd libs not found), so all the dracut modules that require libraries stored in subdirectories must explicitly install them using
inst_libdir_file, which already successfully handles the--sysrootprefix.