add variableTypes before objects #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Id for parent references"" This reverts commit ba7a1be.
|
@keba-uso : can you take a look on this? I can't select you as an reviewer from the dropdown. |
|
Unfortunately, I did not get any notification about this mention and I just saw this PR. PR looks good, I will test this PR with the newest open62541 version and check if it fixes #201 (and possibly adds support for additional UA-Nodesets). |
|
Tested all current nodesetLoade-related features within open62541. All currently supported UA-Nodesets work well. Unfortunately, as I've seen from my test results, this change does not fix #201. However, support for MTConnect companion specification is now available (issue with this companion specification was referenced in #205). From my point of view, this PR could be considered as merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consider ParentNodeId for parent references
Fix for #201