V2 Feature: /search now returns more helpful data
#535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created to address minor errorsin how the Open5e API V2
/searchendpoint functioned which were exposed during the front-end migration over to V2.These changes update which fields are included in the
objectproperties of results returned by the/searchendpoint. In some cases these were changed to improve aesthetics and navigation on the front-end (ie. for a creature, it is much more important to sees its Type on the /search page, rather than, say, its AC), but in other cases these extra fields are vital to link to the correct page on the website (ie. the CharacterClass endpoint now returns both base- and sub- classes, these resources are accessed via different URL structures, so it is critical to have this information on the FE if we want to link to the searched resource)