-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api import adjust #337
Closed
Closed
Api import adjust #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does break the /manifest endpoint. |
This also addresses #258 |
This was referenced Oct 16, 2023
FYI this needs a change because of bonus actions. |
I was definitely doing some wonky shit on this one. I branched from the wrong place. Closing. I'll resubmit something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!!! BIG CHANGE !!!
This PR will modify the directory structure so that data will be sorted into /data/v1 and /data/v2/, and all data fields are lined up correctly with their relevant models.
This now uses fixtures instead of custom import logic for data import.
Quicksetup can be used exactly like it was before.
I tested this by reviewing various models before and after and confirming the data appeared as expected.
I deprecated a LOT of logic (importer, populatedb, quickload).