Enhance Zephyr bluetooth GAP #2
Annotations
13 errors, 6 warnings, and 10 notices
Run Compliance Tests:
include/zephyr/bluetooth/classic/classic.h#L311
include/zephyr/bluetooth/classic/classic.h:311 "foo* bar" should be "foo *bar"
|
Run Compliance Tests:
include/zephyr/bluetooth/conn.h#L2690
include/zephyr/bluetooth/conn.h:2690 trailing whitespace
|
Run Compliance Tests:
include/zephyr/bluetooth/conn.h#L2734
include/zephyr/bluetooth/conn.h:2734 "foo* bar" should be "foo *bar"
|
Run Compliance Tests:
subsys/bluetooth/host/classic/keys_br.c#L199
subsys/bluetooth/host/classic/keys_br.c:199 "foo* bar" should be "foo *bar"
|
Run Compliance Tests:
subsys/bluetooth/host/conn.c#L4532
subsys/bluetooth/host/conn.c:4532 "foo* bar" should be "foo *bar"
|
Run Compliance Tests
Process completed with exit code 7.
|
check-warns:
Checkpatch.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#coding-style for more details.
SPACE_BEFORE_TAB: please, no space before tabs
File:include/zephyr/bluetooth/classic/classic.h
Line:234
SPACE_BEFORE_TAB: please, no space before tabs
File:include/zephyr/bluetooth/classic/classic.h
Line:235
POINTER_LOCATION: "foo* bar" should be "foo *bar"
File:include/zephyr/bluetooth/classic/classic.h
Line:311
LONG_LINE: line length of 102 exceeds 100 columns
File:include/zephyr/bluetooth/classic/classic.h
Line:320
TRAILING_WHITESPACE: trailing whitespace
File:include/zephyr/bluetooth/conn.h
Line:2690
POINTER_LOCATION: "foo* bar" should be "foo *bar"
File:include/zephyr/bluetooth/conn.h
Line:2734
POINTER_LOCATION: "foo* bar" should be "foo *bar"
File:subsys/bluetooth/host/classic/keys_br.c
Line:199
UNNECESSARY_ELSE: else is not generally useful after a break or return
File:subsys/bluetooth/host/conn.c
Line:2826
POINTER_LOCATION: "foo* bar" should be "foo *bar"
File:subsys/bluetooth/host/conn.c
Line:4532
LONG_LINE_COMMENT: line length of 113 exceeds 100 columns
File:subsys/bluetooth/host/conn_internal.h
Line:67
|
check-warns:
GitDiffCheck.txt#L1
Git conflict markers and whitespace errors are not allowed in added changes
171035d47c1f71c3f6bd05346a36ccd3c71c2af4: include/zephyr/bluetooth/conn.h:2620: trailing whitespace.
|
check-warns:
Gitlint.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
Commit 0be6e80c8f:
1: UC2 Signed-off-by: must have a full name
Commit 5af255cb8f:
1: UC2 Signed-off-by: must have a full name
Commit d6af64624a:
1: UC2 Signed-off-by: must have a full name
Commit 571db58ede:
1: UC2 Signed-off-by: must have a full name
Commit 339005e321:
1: UC2 Signed-off-by: must have a full name
Commit 59a5481d9b:
1: UC2 Signed-off-by: must have a full name
Commit 439e1907f9:
1: UC2 Signed-off-by: must have a full name
Commit 1c6618a382:
1: UC2 Signed-off-by: must have a full name
Commit f1ed2ef187:
1: UC2 Signed-off-by: must have a full name
Commit 171035d47c:
1: UC2 Signed-off-by: must have a full name
Commit d792def970:
1: UC2 Signed-off-by: must have a full name
Commit da245c472d:
1: UC2 Signed-off-by: must have a full name
5: UC4 Commit message body line exceeds max length (96>75): "Rootcause:type of sem->limit is unsigned int and the type of semcount on nuttx os is singed int,"
6: UC4 Commit message body line exceeds max length (121>75): "(int)sem->limit is minimum when sem->limit value is 0xFFFFFFF, unexpected result of semcount compare with (int)sem->limit"
|
check-warns:
Identity.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-guidelines for more details
0be6e80c8fdb3aa1cf5eb1d96db89d1f7057222e: author email (fangzhenwei <[email protected]>) does not follow the syntax: First Last <email>.
5af255cb8f13b7ea8bed23eec4810e0b4d29888a: author email (fangzhenwei <[email protected]>) does not follow the syntax: First Last <email>.
d6af64624aaf51c273651976e812ddc7a4cff685: author email (fangzhenwei <[email protected]>) does not follow the syntax: First Last <email>.
571db58eded59659a610e0b6c372111d067e73fc: author email (fangzhenwei <[email protected]>) does not follow the syntax: First Last <email>.
339005e3213f911c19692587b65b10384954fe76: author email (fangzhenwei <[email protected]>) does not follow the syntax: First Last <email>.
59a5481d9b02a8aad8658a2dfb8b6d72b091b37a: author email (fangzhenwei <[email protected]>) does not follow the syntax: First Last <email>.
439e1907f99c8fcf2a27e409281dea830ea0a8ee: author email (fangzhenwei <[email protected]>) does not follow the syntax: First Last <email>.
1c6618a3824ce6bcdd7128620970e176a156d880: author email (fangzhenwei <[email protected]>) does not follow the syntax: First Last <email>.
f1ed2ef18736a9f1388a00301b4086117618cdc9: author email (fangzhenwei <[email protected]>) does not follow the syntax: First Last <email>.
171035d47c1f71c3f6bd05346a36ccd3c71c2af4: author email (fangzhenwei <[email protected]>) does not follow the syntax: First Last <email>.
d792def9708351237b143ef3d27abbb4063c856d: author email (fangzhenwei <[email protected]>) does not follow the syntax: First Last <email>.
da245c472d3d2b57da75e12410105e53a5e25f8d: author email (fangzhenwei <[email protected]>) does not follow the syntax: First Last <email>.
|
check-warns:
Kconfig.txt#L1
See https://docs.zephyrproject.org/latest/build/kconfig/tips.html for more details.
Kconfig:19: '$APPSDIR/external/zblue/zblue/subsys/bluetooth/Kconfig' not found (in 'source "$APPSDIR/external/zblue/zblue/subsys/bluetooth/Kconfig"'). Check that environment variables are set correctly (e.g. $srctree, which is set to '/home/runner/work/external_zblue/external_zblue'). Also note that unset environment variables expand to the empty string.
|
check-warns:
KconfigBasicNoModules.txt#L1
See https://docs.zephyrproject.org/latest/build/kconfig/tips.html for more details.
Kconfig:19: '$APPSDIR/external/zblue/zblue/subsys/bluetooth/Kconfig' not found (in 'source "$APPSDIR/external/zblue/zblue/subsys/bluetooth/Kconfig"'). Check that environment variables are set correctly (e.g. $srctree, which is set to '/home/runner/work/external_zblue/external_zblue'). Also note that unset environment variables expand to the empty string.
|
check-warns
Process completed with exit code 1.
|
Run Compliance Tests:
include/zephyr/bluetooth/classic/classic.h#L234
include/zephyr/bluetooth/classic/classic.h:234 please, no space before tabs
|
Run Compliance Tests:
include/zephyr/bluetooth/classic/classic.h#L235
include/zephyr/bluetooth/classic/classic.h:235 please, no space before tabs
|
Run Compliance Tests:
include/zephyr/bluetooth/classic/classic.h#L320
include/zephyr/bluetooth/classic/classic.h:320 line length of 102 exceeds 100 columns
|
Run Compliance Tests:
subsys/bluetooth/host/conn.c#L2826
subsys/bluetooth/host/conn.c:2826 else is not generally useful after a break or return
|
Run Compliance Tests:
subsys/bluetooth/host/conn_internal.h#L67
subsys/bluetooth/host/conn_internal.h:67 line length of 113 exceeds 100 columns
|
check-warns:
ClangFormat.txt#L1
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change:
- uint8_t key_type;
- uint8_t key[16];
+ uint8_t key_type;
+ uint8_t key[16];
File:include/zephyr/bluetooth/classic/classic.h
Line:281
You may want to run clang-format on this change:
-int bt_get_bond_info_br(const bt_addr_t* bdaddr, struct bt_bond_info_br *info);
+int bt_get_bond_info_br(const bt_addr_t *bdaddr, struct bt_bond_info_br *info);
File:include/zephyr/bluetooth/classic/classic.h
Line:312
You may want to run clang-format on this change:
-typedef void (*bt_br_remote_name_req_cb_t)(const bt_addr_t *bdaddr, const char *name, uint8_t status);
+typedef void (*bt_br_remote_name_req_cb_t)(const bt_addr_t *bdaddr, const char *name,
+ uint8_t status);
File:include/zephyr/bluetooth/classic/classic.h
Line:321
You may want to run clang-format on this change:
- *
+ *
File:include/zephyr/bluetooth/conn.h
Line:2691
You may want to run clang-format on this change:
-int bt_conn_set_link_policy_settings(struct bt_conn* conn, uint16_t policy);
+int bt_conn_set_link_policy_settings(struct bt_conn *conn, uint16_t policy);
File:include/zephyr/bluetooth/conn.h
Line:2735
You may want to run clang-format on this change:
-#define BT_HCI_OP_SNIFF_MODE BT_OP(BT_OGF_LINK_POLICY, 0x0003) /* 0x0803 */
+#define BT_HCI_OP_SNIFF_MODE BT_OP(BT_OGF_LINK_POLICY, 0x0003) /* 0x0803 */
File:include/zephyr/bluetooth/hci_types.h
Line:560
You may want to run clang-format on this change:
-#define BT_HCI_OP_EXIT_SNIFF_MODE BT_OP(BT_OGF_LINK_POLICY, 0x0004) /* 0x0804 */
+#define BT_HCI_OP_EXIT_SNIFF_MODE BT_OP(BT_OGF_LINK_POLICY, 0x0004) /* 0x0804 */
struct bt_hci_cp_exit_sniff_mode {
uint16_t handle;
} __packed;
-#define BT_HCI_OP_ROLE_DISCOVERY BT_OP(BT_OGF_LINK_POLICY, 0x0009) /* 0x0809 */
+#define BT_HCI_OP_ROLE_DISCOVERY BT_OP(BT_OGF_LINK_POLICY, 0x0009) /* 0x0809 */
struct bt_hci_cp_role_discovery {
- uint8_t status;
- uint16_t handle;
- uint8_t role;
-} __packed;
-
-#define BT_HCI_OP_SWITCH_ROLE BT_OP(BT_OGF_LINK_POLICY, 0x000b) /* 0x080b */
+ uint8_t status;
+ uint16_t handle;
+ uint8_t role;
+} __packed;
+
+#define BT_HCI_OP_SWITCH_ROLE BT_OP(BT_OGF_LINK_POLICY, 0x000b) /* 0x080b */
struct bt_hci_cp_switch_role {
bt_addr_t bdaddr;
- uint8_t role;
+ uint8_t role;
} __packed;
#define BT_HCI_POLICY_ROLE_SWITCH BIT(0)
#define BT_HCI_POLICY_HOLD_MODE BIT(1)
#define BT_HCI_POLICY_SNIFF_MODE BIT(2)
-#define BT_HCI_OP_READ_LINK_POLICY_SETTINGS BT_OP(BT_OGF_LINK_POLICY, 0x000c) /* 0x080c */
-
-#define BT_HCI_OP_WRITE_LINK_POLICY_SETTINGS BT_OP(BT_OGF_LINK_POLICY, 0x000d) /* 0x080d */
+#define BT_HCI_OP_READ_LINK_POLICY_SETTINGS BT_OP(BT_OGF_LINK_POLICY, 0x000c) /* 0x080c */
+
+#define BT_HCI_OP_WRITE_LINK_POLICY_SETTINGS BT_OP(BT_OGF_LINK_POLICY, 0x000d) /* 0x080d */
File:include/zephyr/bluetooth/hci_types.h
Line:593
You may want to run clang-format on this change:
- uint8_t delete_all;
-} __packed;
-
-#define BT_HCI_OP_DELETE_STORED_LINK_KEY BT_OP(BT_OGF_BASEBAND, 0x0012) /* 0x0c12 */
+ uint8_t delete_all;
+} __packed;
+
+#define BT_HCI_OP_DELETE_STORED_LINK_KEY BT_OP(BT_OGF_BASEBAND, 0x0012) /* 0x0c12 */
File:include/zephyr/bluetooth/hci_types.h
Line:611
You may want to run clang-format on this change:
-#define BT_HCI_OP_WRITE_PAGE_SCAN_ACTIVITY BT_OP(BT_OGF_BASEBAND, 0x001c) /* 0x0c1c */
-#define BT_HCI_OP_WRITE_INQUIRY_SCAN_ACTIVITY BT_OP(BT_OGF_BASEBAND, 0x001e) /* 0x0c1e */
+#define BT_HCI_OP_WRITE_PAGE_SCAN_ACTIVITY BT_OP(BT_OGF_BASEBAND, 0x001c) /* 0x0c1c */
+#define BT_HCI_OP_WRITE_INQUIRY_SCAN_ACTIVITY BT_OP(BT_OGF_BASEBAND, 0x001e) /* 0x0c1e */
File:include/zephyr/bluetooth/hci_types.h
Line:641
You may want to run clang-format on this change:
-#define BT_HCI_OP_WRITE_LINK_SUPERVISION_TIMEOUT BT_OP(BT_OGF_BASEBAND, 0x0037) /* 0x0c37 */
+#define BT_HCI_OP_WRITE_LINK_SUPERVISION_TIMEOUT BT_OP(BT_OGF_BASEBAND, 0x0037) /* 0x0c37 */
struct bt_h
|
Run Compliance Tests:
include/zephyr/bluetooth/classic/classic.h#L281
include/zephyr/bluetooth/classic/classic.h:281
- uint8_t key_type;
- uint8_t key[16];
+ uint8_t key_type;
+ uint8_t key[16];
|
Run Compliance Tests:
include/zephyr/bluetooth/classic/classic.h#L312
include/zephyr/bluetooth/classic/classic.h:312
-int bt_get_bond_info_br(const bt_addr_t* bdaddr, struct bt_bond_info_br *info);
+int bt_get_bond_info_br(const bt_addr_t *bdaddr, struct bt_bond_info_br *info);
|
Run Compliance Tests:
include/zephyr/bluetooth/classic/classic.h#L321
include/zephyr/bluetooth/classic/classic.h:321
-typedef void (*bt_br_remote_name_req_cb_t)(const bt_addr_t *bdaddr, const char *name, uint8_t status);
+typedef void (*bt_br_remote_name_req_cb_t)(const bt_addr_t *bdaddr, const char *name,
+ uint8_t status);
|
Run Compliance Tests:
include/zephyr/bluetooth/conn.h#L2691
include/zephyr/bluetooth/conn.h:2691
- *
+ *
|
Run Compliance Tests:
include/zephyr/bluetooth/conn.h#L2735
include/zephyr/bluetooth/conn.h:2735
-int bt_conn_set_link_policy_settings(struct bt_conn* conn, uint16_t policy);
+int bt_conn_set_link_policy_settings(struct bt_conn *conn, uint16_t policy);
|
Run Compliance Tests:
include/zephyr/bluetooth/hci_types.h#L560
include/zephyr/bluetooth/hci_types.h:560
-#define BT_HCI_OP_SNIFF_MODE BT_OP(BT_OGF_LINK_POLICY, 0x0003) /* 0x0803 */
+#define BT_HCI_OP_SNIFF_MODE BT_OP(BT_OGF_LINK_POLICY, 0x0003) /* 0x0803 */
|
Run Compliance Tests:
include/zephyr/bluetooth/hci_types.h#L593
include/zephyr/bluetooth/hci_types.h:593
-#define BT_HCI_OP_EXIT_SNIFF_MODE BT_OP(BT_OGF_LINK_POLICY, 0x0004) /* 0x0804 */
+#define BT_HCI_OP_EXIT_SNIFF_MODE BT_OP(BT_OGF_LINK_POLICY, 0x0004) /* 0x0804 */
struct bt_hci_cp_exit_sniff_mode {
uint16_t handle;
} __packed;
-#define BT_HCI_OP_ROLE_DISCOVERY BT_OP(BT_OGF_LINK_POLICY, 0x0009) /* 0x0809 */
+#define BT_HCI_OP_ROLE_DISCOVERY BT_OP(BT_OGF_LINK_POLICY, 0x0009) /* 0x0809 */
struct bt_hci_cp_role_discovery {
- uint8_t status;
- uint16_t handle;
- uint8_t role;
-} __packed;
-
-#define BT_HCI_OP_SWITCH_ROLE BT_OP(BT_OGF_LINK_POLICY, 0x000b) /* 0x080b */
+ uint8_t status;
+ uint16_t handle;
+ uint8_t role;
+} __packed;
+
+#define BT_HCI_OP_SWITCH_ROLE BT_OP(BT_OGF_LINK_POLICY, 0x000b) /* 0x080b */
struct bt_hci_cp_switch_role {
bt_addr_t bdaddr;
- uint8_t role;
+ uint8_t role;
} __packed;
#define BT_HCI_POLICY_ROLE_SWITCH BIT(0)
#define BT_HCI_POLICY_HOLD_MODE BIT(1)
#define BT_HCI_POLICY_SNIFF_MODE BIT(2)
-#define BT_HCI_OP_READ_LINK_POLICY_SETTINGS BT_OP(BT_OGF_LINK_POLICY, 0x000c) /* 0x080c */
-
-#define BT_HCI_OP_WRITE_LINK_POLICY_SETTINGS BT_OP(BT_OGF_LINK_POLICY, 0x000d) /* 0x080d */
+#define BT_HCI_OP_READ_LINK_POLICY_SETTINGS BT_OP(BT_OGF_LINK_POLICY, 0x000c) /* 0x080c */
+
+#define BT_HCI_OP_WRITE_LINK_POLICY_SETTINGS BT_OP(BT_OGF_LINK_POLICY, 0x000d) /* 0x080d */
|
Run Compliance Tests:
include/zephyr/bluetooth/hci_types.h#L611
include/zephyr/bluetooth/hci_types.h:611
- uint8_t delete_all;
-} __packed;
-
-#define BT_HCI_OP_DELETE_STORED_LINK_KEY BT_OP(BT_OGF_BASEBAND, 0x0012) /* 0x0c12 */
+ uint8_t delete_all;
+} __packed;
+
+#define BT_HCI_OP_DELETE_STORED_LINK_KEY BT_OP(BT_OGF_BASEBAND, 0x0012) /* 0x0c12 */
|
Run Compliance Tests:
include/zephyr/bluetooth/hci_types.h#L641
include/zephyr/bluetooth/hci_types.h:641
-#define BT_HCI_OP_WRITE_PAGE_SCAN_ACTIVITY BT_OP(BT_OGF_BASEBAND, 0x001c) /* 0x0c1c */
-#define BT_HCI_OP_WRITE_INQUIRY_SCAN_ACTIVITY BT_OP(BT_OGF_BASEBAND, 0x001e) /* 0x0c1e */
+#define BT_HCI_OP_WRITE_PAGE_SCAN_ACTIVITY BT_OP(BT_OGF_BASEBAND, 0x001c) /* 0x0c1c */
+#define BT_HCI_OP_WRITE_INQUIRY_SCAN_ACTIVITY BT_OP(BT_OGF_BASEBAND, 0x001e) /* 0x0c1e */
|
Run Compliance Tests:
include/zephyr/bluetooth/hci_types.h#L836
include/zephyr/bluetooth/hci_types.h:836
-#define BT_HCI_OP_WRITE_LINK_SUPERVISION_TIMEOUT BT_OP(BT_OGF_BASEBAND, 0x0037) /* 0x0c37 */
+#define BT_HCI_OP_WRITE_LINK_SUPERVISION_TIMEOUT BT_OP(BT_OGF_BASEBAND, 0x0037) /* 0x0c37 */
struct bt_hci_cp_write_link_supervision_timeout {
uint16_t handle;
uint16_t timeout;
} __packed;
-#define BT_HCI_OP_WRITE_INQUIRY_SCAN_TYPE BT_OP(BT_OGF_BASEBAND, 0x0043) /* 0x0c43 */
+#define BT_HCI_OP_WRITE_INQUIRY_SCAN_TYPE BT_OP(BT_OGF_BASEBAND, 0x0043) /* 0x0c43 */
#define BT_HCI_OP_WRITE_INQUIRY_MODE BT_OP(BT_OGF_BASEBAND, 0x0045) /* 0x0c45 */
struct bt_hci_cp_write_inquiry_mode {
uint8_t mode;
} __packed;
-#define BT_HCI_OP_WRITE_PAGE_SCAN_TYPE BT_OP(BT_OGF_BASEBAND, 0x0047) /* 0x0c47 */
+#define BT_HCI_OP_WRITE_PAGE_SCAN_TYPE BT_OP(BT_OGF_BASEBAND, 0x0047) /* 0x0c47 */
struct bt_hci_cp_write_scan_type {
- uint8_t type;
+ uint8_t type;
|
Loading