swapped out symbols for numbers

reasoning_gym/games/puzzle24.py

@@ -90,13 +90,16 @@ def __getitem__(self, idx: int) -> dict:
             expr, numbers, syms = self._generate_candidate_expression(rng, 4)
             if expr.subs({sym: num for sym, num in zip(syms, numbers)}) == 24:
                 break
+        expr_str = str(expr)
+        for i, sym in enumerate(syms):
+            expr_str = expr_str.replace(str(sym), str(numbers[i]))
 
         question = QUESTION_TEMPLATE.format(
             numbers=", ".join(map(str, numbers)), operators=", ".join(self.config.operators)
         )
         return {
             "question": question,
-            "answer": str(expr),
+            "answer": expr_str,
             "metadata": {
                 "numbers": numbers,
                 "expression": expr,

tests/test_puzzle24.py

@@ -59,7 +59,17 @@ def test_puzzle24_basic_properties():
         assert num_str in item["question"]
 
 
-def test_puzzle24_score_answer():
+def test_puzzle24_score_answer_correct():
+    """Test the score_answer method for correct answers"""
+    config = Puzzle24Config(seed=42)
+    dataset = Puzzle24Dataset(config)
+    for item in dataset:
+        answer = item["answer"]
+        print(item)
+        assert dataset.score_answer(answer, item) == 1.0
+
+
+def test_puzzle24_score_answer_individual():
     """Test the score_answer method"""
     config = Puzzle24Config(seed=42)
     dataset = Puzzle24Dataset(config)