-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds mistralai
as a gen_ai.system
attribute value
#1719
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Adrian Cole <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This addition looks good to me.
@@ -61,6 +61,10 @@ groups: | |||
stability: experimental | |||
value: "groq" | |||
brief: 'Groq' | |||
- id: mistralai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it's spelled as two words in the docs and on the trademark I believe it should be
- id: mistralai | |
- id: mistral_ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so in the README I wrote this:
"mistralai", not "mistral" as their client library is named "mistralai", despite some of their models named "mistral-XXX"
do we want to use a convention different than what they are using? ok by me, but worth the question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bam4d since you are from mistral, maybe you can answer this question. OpenTelemetry will make signals like metrics, and a dimension of the metrics is where chat requests are coming from. For Mistral AI, should the string be "mistralai" or "mistral_ai" (or something else). We just want to use a coherent value and there are multiple seemingly correct choices.
Thanks for letting us randomly ping you.
This extends GenAI System to include Mistral AI. This accessed either via its native 'mistralai' API or via OpenAI libraries.
This is a follow-up to #1655
Changes
Added the following:
Merge requirement checklist
[chore]