-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First stab at documenting the art of defining semantic conventions #1707
base: main
Are you sure you want to change the base?
First stab at documenting the art of defining semantic conventions #1707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
docs/general/how-to-define-semantic-conventions.md:69
- The phrase 'are involved into instrumentation efforts' should be 'are involved in instrumentation efforts'.
are involved into instrumentation efforts, and are committed to be the point of contact for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great start!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor grammar feedback
2afb348
to
6f90089
Compare
While I’m not opposed to this PR and appreciate the idea of having a clear path for defining semantic conventions, I would like to raise a concern about donation of ECS into Otel, where we still have a significant number of new namespaces / new fields to be added to the Otel and this could potentially slow down the merger. Should we consider establishing a short-circuit path to streamline the donation process? |
@trisch-me This PR outlines path to success and best practices. Most of the language used there is non-normative. |
d91704c
to
abecb36
Compare
A lot of todos, which I'd like to tackle in follow up PRs (hopefully with the help of others)
Merge requirement checklist
[chore]