Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(languages/java/intro): current section links BOM #6180

Merged
merged 2 commits into from
Feb 4, 2025
Merged

docs(languages/java/intro): current section links BOM #6180

merged 2 commits into from
Feb 4, 2025

Conversation

guspan-tanadi
Copy link
Contributor

No description provided.

@guspan-tanadi guspan-tanadi requested a review from a team as a code owner February 3, 2025 02:15
@opentelemetrybot opentelemetrybot requested review from a team February 3, 2025 02:15
trask
trask approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/docs-maintainers I thought anchors were being verified somehow in this repo? (at least I think that's how we've found issues in the semconv repo before through this repo)

@opentelemetrybot opentelemetrybot requested review from a team February 3, 2025 23:53
@chalin
Copy link
Contributor

chalin commented Feb 4, 2025

@open-telemetry/docs-maintainers I thought anchors were being verified somehow in this repo? (at least I think that's how we've found issues in the semconv repo before through this repo)

Links into the spec pages are "localized" -- they become local paths rather than external URLs -- when published this repo, which is why anchor IDs are being checked. It seems like htmltest doesn't check anchor IDs on external links after all :-/ 🤷🏼‍♂️

@chalin
Copy link
Contributor

chalin commented Feb 4, 2025

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13126678727

@opentelemetrybot
Copy link
Collaborator

fix:refcache was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@chalin
Copy link
Contributor

chalin commented Feb 4, 2025 •
edited
Loading

Links into the spec pages are "localized" -- they become local paths rather than external URLs -- when published this repo, which is why anchor IDs are being checked. It seems like htmltest doesn't check anchor IDs on external links after all :-/ 🤷🏼‍♂️

I've just modified our test scripts to check anchors for external links too. For the main issue tracker, see:

@chalin chalin mentioned this pull request Feb 4, 2025
Open
16 tasks
@chalin chalin added this pull request to the merge queue Feb 4, 2025
Merged via the queue into open-telemetry:main with commit 57676e2 Feb 4, 2025
18 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

@guspan-tanadi guspan-tanadi deleted the sectionlinks branch February 4, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@chalin chalin chalin approved these changes

@jeanbisutti jeanbisutti jeanbisutti approved these changes

@steverao steverao steverao approved these changes

Assignees
No one assigned
Labels
sig:java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guspan-tanadi @chalin @opentelemetrybot @trask @jeanbisutti @steverao