Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ja] translate demo/docker-deployment into ja #6098

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Msksgm
Copy link

@Msksgm Msksgm commented Jan 28, 2025

translated demo/docker-deployment page.

Copy link

linux-foundation-easycla bot commented Jan 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@opentelemetrybot opentelemetrybot requested review from a team January 28, 2025 13:17
@Msksgm Msksgm force-pushed the ja/demo/docker-deployment branch 5 times, most recently from f8adbfd to fce6eb1 Compare January 29, 2025 23:41
@Msksgm Msksgm marked this pull request as ready for review January 29, 2025 23:43
@Msksgm Msksgm requested a review from a team as a code owner January 29, 2025 23:43
@Msksgm Msksgm closed this Jan 29, 2025
@Msksgm Msksgm reopened this Jan 29, 2025
@Msksgm Msksgm force-pushed the ja/demo/docker-deployment branch 3 times, most recently from f06c7d0 to 75d329b Compare January 30, 2025 23:01
@Msksgm Msksgm force-pushed the ja/demo/docker-deployment branch from 75d329b to 646aa88 Compare January 31, 2025 22:21
Copy link
Contributor

@ymotongpoo ymotongpoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contributions, @Msksgm!! Though I left minor comments, overall it looks great!


## ウェブストアとテレメトリーの確認

イメージがビルドされ、コンテナが開始されるとアクセスできるようになります:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コロンは日本語の文法には無いため、「以下にアクセスできるようになります。」等と変更してください。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymotongpoo

Thank you for your review.
I've fixed it in a bellow commit with similar mistakes.

a73874c

デフォルトでは、デモアプリケーションは 8080 ポートにバウンドされたすべてのブラウザのトラフィックに対してプロキシを開始します。
ポート番号を変更するには、デモを開始する前に環境変数 `ENVOY_PORT` を設定してください。

- 例、8081 ポートを利用する場合[^1]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「次の設定は8081ポートを利用する場合の例です。」

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymotongpoo

Thank you for review.
I've fixed it in a bellow commit.

ef6a0c4

おそらく、あなたがすでに所持しているオブザーバビリティバックエンド(たとえば、Jaeger、Zipkin、または[選択したベンダー](/ecosystem/vendors/)のいずれかの既存インスタンス)のデモアプリケーションとしてウェブストアを利用したいでしょう。

OpenTelemetry コレクターはテレメトリーデータを複数のバックエンドに送信するのに利用可能です。
デフォルトで、デモアプリケーションのコレクターは 2 つのファイルから設定をマージします:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コロンを読点に。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymotongpoo

Thank you for your review.
I've fixed it in a bellow commit.

8a7b6f9


あなたのバックエンドに追加するために、エディターで[src/otelcollector/otelcol-config-extras.yml](https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/otelcollector/otelcol-config-extras.yml)ファイルを開いてください。

- 新しいエクスポーターを追加することで始めます。例えば、もしあなたのバックエンドが OTLP over HTTP をサポートしているのであれば、以下を追加してください:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 例えば→開く
  • コロン→読点

Copy link
Author

@Msksgm Msksgm Feb 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymotongpoo

Thank you for your review.
I tried to fix it in a bellow commit.

ece722b

However, I might not be sure to understand the meanings of a bellow message.
Is it right to add space between "始めます" to "例えば"?
Sorry, I'm not used to translating these docs.
Please give me more information if I was mistaken again.
Thank you.

例えば→開く

@opentelemetrybot opentelemetrybot requested a review from a team February 2, 2025 07:51
@Msksgm
Copy link
Author

Msksgm commented Feb 2, 2025

@ymotongpoo

Thank you for your review.
I've fixed and replied all your review.
Please check it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants