Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to semconv attribute naming guidance #4376

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

trask
Copy link
Member

@trask trask commented Jan 18, 2025

Leaving as draft for now because probably need to wait until after the next semconv release to merge it (when this link will exist https://opentelemetry.io/docs/specs/semconv/general/naming/).

cc @open-telemetry/docs-approvers

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, and yeah, good to merge when released

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @trask.

I'd vote to merge it now since both semconv and the OTel spec will get new releases soon. Otherwise I'll have to patch-fix this on the OTel website side.

WDYT?

/cc @svrnm

@trask
Copy link
Member Author

trask commented Jan 21, 2025

I'd vote to merge it now since both semconv and the OTel spec will get new releases soon. Otherwise I'll have to patch-fix this on the OTel website side.

sure, I've excluded the link from the link check since it doesn't exist, and marked the PR as ready

@trask trask marked this pull request as ready for review January 21, 2025 00:03
@trask trask requested review from a team as code owners January 21, 2025 00:03
@carlosalberto carlosalberto merged commit 0319dea into open-telemetry:main Jan 21, 2025
6 checks passed
@trask trask deleted the attribute-naming-link branch January 21, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants