Skip to content

Commit

Permalink
Update 4290-logger-enabled.md
Browse files Browse the repository at this point in the history
  • Loading branch information
pellared authored Jan 16, 2025
1 parent ccc1b92 commit bb36dd3
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions oteps/logs/4290-logger-enabled.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,6 @@ if trace.SpanContextFromContext(ctx).IsSampled() && logger.Enabled(ctx, params)
```
<!-- markdownlint-enable no-hard-tabs -->

The instrumentation libraries can have a configuration defining
if they emit log records that are not inside sampled spans.
The alternative can be [extending LoggerConfig](#extending-loggerconfig)
so that the instrumentation library code could be simplified.

The addition of `LogRecordProcessor.Enabled` is necessary for
use cases where filtering is dynamic and coupled to processing,
such as (5) and (6).
Expand Down

0 comments on commit bb36dd3

Please sign in to comment.