[Metrics][POC] Use Weak instead of Arc in Counter to respect MeterProvider shutdown #2497
+39
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2497 +/- ##
=====================================
Coverage 77.9% 77.9%
=====================================
Files 123 123
Lines 22888 22909 +21
=====================================
+ Hits 17839 17860 +21
Misses 5049 5049 ☔ View full report in Codecov by Sentry. |
cijothomas
reviewed
Jan 6, 2025
| } | ||
|
|
||
| /// Records an increment to the counter. | ||
| pub fn add(&self, value: T, attributes: &[KeyValue]) { | ||
| self.0.measure(value, attributes) | ||
| if let Some(inner) = self.0.upgrade() { |
There was a problem hiding this comment.
how much is the perf cost for this upgrade as opposed to storing Arc itself?
There was a problem hiding this comment.
There is a considerable perf cost. Check this #2442 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2442
Changes
Weakinstead ofArcin instruments to respectMeterProvidershutdownNote: This also requires
MeterProviderinstance to be valid for metrics to be emitted.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes