fix: Propagate response attributes on Faraday::Error #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current `Faraday` middleware won't report `http.status_code` in cases where an error is raised via another middleware (such as `:raise_error` or `:json`). This adds a special case for subclasses of `Faraday::Error` which have response information available, so that `http.status_code` the span status are still added to the span.
CGA1123
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle and
xuan-cao-swi
as code owners
The committers listed above are authorized under a signed CLA. |
arielvalentin
approved these changes
Mar 22, 2024
|
Thanks for the contribution @CGA1123 ! |
arielvalentin
changed the title
|
Thanks for the speeeeeedy turn-around on this @arielvalentin 🙇♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
Faradaymiddleware won't reporthttp.status_codeincases where an error is raised via another middleware (such as
:raise_erroror:json).This adds a special case for subclasses of
Faraday::Errorwhich haveresponse information available, so that
http.status_code& the spanstatus are still added to the span.