Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop dependency on ruby2_keywords #885

Merged
merged 1 commit into from
Feb 23, 2024
Merged

chore: drop dependency on ruby2_keywords #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions ...entation/active_record/lib/opentelemetry/instrumentation/active_record/instrumentation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ def patch
end

def require_dependencies
# Our patches depend on Ruby 2 Keyword Syntax compatability since it is decorating the existing AR API
# Once we migrate to ActiveSupport Notifications based instrumentation we can remove this require statement.
require 'ruby2_keywords' # rubocop:disable Lint/RedundantRequireStatement
require_relative 'patches/querying'
require_relative 'patches/persistence'
require_relative 'patches/persistence_class_methods'
Expand Down
1 change: 0 additions & 1 deletion instrumentation/active_record/opentelemetry-instrumentation-active_record.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ Gem::Specification.new do |spec|

spec.add_dependency 'opentelemetry-api', '~> 1.0'
spec.add_dependency 'opentelemetry-instrumentation-base', '~> 0.22.1'
spec.add_dependency 'ruby2_keywords'

spec.add_development_dependency 'activerecord', '>= 6.1'
spec.add_development_dependency 'appraisal', '~> 2.5'
Expand Down